kyma icon indicating copy to clipboard operation
kyma copied to clipboard

Published 20 hours ago • verified publisher icon kyma-project

Add a new prow pre-main job with this Flag enabled.

Open mfaizanse opened this issue 2 years ago • 4 comments

Once we have the feature flag to enable new Subscription CRD, we need a new pre-main job to run the tests with the feature flag enables.

  • [ ] Fast-integration tests with new CRD
  • [ ] gcp-eventing pipeline with the new CRD

Followup:

  • [ ] #15815

mfaizanse avatar Sep 16 '22 12:09 mfaizanse

Check if this is pre-requisite: https://github.com/kyma-project/kyma/issues/15684

mfaizanse avatar Sep 30 '22 07:09 mfaizanse

Idea: let's duplicate the normal eventing + the upgrade tests on prow

nachtmaar avatar Sep 30 '22 12:09 nachtmaar

I agree with @mfaizanse that this is a pre requisite to this ticket! And yes we need the upgrade job as well!

raypinto avatar Oct 14 '22 10:10 raypinto

For the fast-integration tests: we need to obtain the ENV variable "ENABLE_NEW_CRD" set from the pipeline, as done here and based on this value check the relevant fields of the spec (for eg: Spec.CleanEventTypes will now be Spec.Types).

Some places that need a change in the FI tests are here, here and here for example.

raypinto avatar Oct 14 '22 12:10 raypinto

PR(s):

  • FI tests: https://github.com/kyma-project/kyma/pull/16197
  • Test-infra:
    • https://github.com/kyma-project/test-infra/pull/6476
    • https://github.com/kyma-project/test-infra/pull/6479

mfaizanse avatar Nov 28 '22 13:11 mfaizanse