kyma icon indicating copy to clipboard operation
kyma copied to clipboard

ssh git url is not parsed correctly by function controller

Open kwiatekus opened this issue 2 years ago • 2 comments

Description Function controler fail to reconcile git functions with ssh url format

Attachments

{"level":"WARN","timestamp":"2022-08-10T07:55:05Z","logger":"controllers.function","caller":"serverless/fsm.go:135","message":"while updating function status: admission webhook \"validation.webhook.serverless.kyma-project.io\" denied the request: validation failed: [invalid source.gitRepository.URL value: parse \"[email protected]:v3/kyma-wookiee/kyma-function/azure-devops-sample-function\": invalid URI for request]","context":{"kind":"Function","name":"fun4-azure-devops-node-ssh","namespace":"default","version":2}}
apiVersion: serverless.kyma-project.io/v1alpha1
kind: GitRepository
metadata:
...
  name: azure-devops-ssh
  namespace: default
...
spec:
  auth:
    secretName: azure-repo-ssh-key
    type: key
  url: >-
    [email protected]:v3/kyma-wookiee/kyma-function/azure-devops-sample-function

kwiatekus avatar Aug 10 '22 08:08 kwiatekus

PR from @moelsayed https://github.com/kyma-project/kyma/pull/14966/files

kwiatekus avatar Aug 10 '22 09:08 kwiatekus

Looks like this url parsing is related to azure devops case ( where ssh-like git url does not end with .git )

kwiatekus avatar Aug 12 '22 12:08 kwiatekus