kyma
kyma copied to clipboard
Published
20 hours ago •
kyma-project
kyma-project
Fix "Kyma subscription and NATS infra are not in sync"
Description
Changes in the PR:
- Fixes the problem that an invalid subscription sink causes the NATS subscriptions to not be in sync with the eventing subscription
- To fix and catch regression, two tests were added:
- One test tests what happens when adding a new filter
- The other test tests what happens when deleting a new filter
This PR also adds several improvements to the controller integration testing in general:
- Make testing more resilient by using
Eventually - Print a description then a gingko matcher fails
- Add the support to check for NATS subscriptions with every possible event-type and not only hardcoded to order.created.v1 event type
- Add logs to the table tests to make it easier to understand in which step a matcher failed
- Fixes the problem
test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
Related issue(s)
Closes https://github.com/kyma-project/kyma/issues/14152
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
🥰 Documentation preview ready! 🥰
| Name | Link |
|---|---|
| Latest commit | aefaa5bc81d9bf09f7fd9f2f30f89fc470b8ca2c |
| Latest deploy log | https://app.netlify.com/sites/kyma-project-docs-preview/deploys/62f5092cbfb0640008292516 |
| Deploy Preview | https://deploy-preview-14742--kyma-project-docs-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@nachtmaar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pre-main-test-infra-pjtester-v2 | f0b231f0fb6e8cfff90921257642e1a6289c34ae | link | true | /test pre-main-test-infra-pjtester-v2 |
| pre-kyma-components-directory-size-exporter | aefaa5bc81d9bf09f7fd9f2f30f89fc470b8ca2c | link | true | /test pre-kyma-components-directory-size-exporter |
| pre-kyma-components-eventing-controller | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-kyma-components-eventing-controller |
| pre-main-kyma-protecode-guard | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-kyma-protecode-guard |
| pre-kyma-artifacts | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-kyma-artifacts |
| pre-main-check-users-map | 754dabb4b4f499b331afe040e69c995d10970a63 | link | false | /test pre-main-check-users-map |
| pre-main-kyma-integration-k3d-telemetry | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-kyma-integration-k3d-telemetry |
| pull-directory-size-exporter-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-directory-size-exporter-unit-test |
| pull-application-operator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-application-operator-unit-test |
| pull-central-application-gateway-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-central-application-gateway-unit-test |
| pull-central-application-connectivity-validator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-central-application-connectivity-validator-unit-test |
| pull-telemetry-operator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-telemetry-operator-unit-test |
| pull-compass-runtime-agent-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-compass-runtime-agent-unit-test |
| pull-event-publisher-proxy-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-event-publisher-proxy-unit-test |
| pull-function-controller-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-controller-unit-test |
| pull-eventing-controller-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-eventing-controller-unit-test |
| pull-function-jobinit-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-jobinit-build |
| pull-function-webhook-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-webhook-build |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@nachtmaar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pre-main-test-infra-pjtester-v2 | f0b231f0fb6e8cfff90921257642e1a6289c34ae | link | true | /test pre-main-test-infra-pjtester-v2 |
| pre-kyma-components-directory-size-exporter | aefaa5bc81d9bf09f7fd9f2f30f89fc470b8ca2c | link | true | /test pre-kyma-components-directory-size-exporter |
| pre-kyma-components-eventing-controller | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-kyma-components-eventing-controller |
| pre-main-kyma-protecode-guard | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-kyma-protecode-guard |
| pre-kyma-artifacts | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-kyma-artifacts |
| pre-main-check-users-map | 754dabb4b4f499b331afe040e69c995d10970a63 | link | false | /test pre-main-check-users-map |
| pre-main-kyma-integration-k3d-telemetry | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-kyma-integration-k3d-telemetry |
| pull-directory-size-exporter-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-directory-size-exporter-unit-test |
| pull-application-operator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-application-operator-unit-test |
| pull-central-application-gateway-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-central-application-gateway-unit-test |
| pull-central-application-connectivity-validator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-central-application-connectivity-validator-unit-test |
| pull-telemetry-operator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-telemetry-operator-unit-test |
| pull-compass-runtime-agent-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-compass-runtime-agent-unit-test |
| pull-function-controller-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-controller-unit-test |
| pull-function-jobinit-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-jobinit-build |
| pull-function-webhook-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-webhook-build |
| pull-event-publisher-proxy-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-event-publisher-proxy-unit-test |
| pull-eventing-controller-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-eventing-controller-unit-test |
| pull-kyma-pjtester | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-kyma-pjtester |
| pull-webhook-cert-init-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-webhook-cert-init-build |
| pull-function-runtimes-python39-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-python39-build |
| pull-function-runtimes-nodejs16-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-nodejs16-build |
| pull-function-runtimes-nodejs14-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-nodejs14-build |
| pull-function-java11-jvm-alpha-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-java11-jvm-alpha-build |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@nachtmaar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pre-main-test-infra-pjtester-v2 | f0b231f0fb6e8cfff90921257642e1a6289c34ae | link | true | /test pre-main-test-infra-pjtester-v2 |
| pre-kyma-components-directory-size-exporter | aefaa5bc81d9bf09f7fd9f2f30f89fc470b8ca2c | link | true | /test pre-kyma-components-directory-size-exporter |
| pre-kyma-components-eventing-controller | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-kyma-components-eventing-controller |
| pre-main-kyma-protecode-guard | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-kyma-protecode-guard |
| pre-kyma-artifacts | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-kyma-artifacts |
| pre-main-check-users-map | 754dabb4b4f499b331afe040e69c995d10970a63 | link | false | /test pre-main-check-users-map |
| pre-main-kyma-integration-k3d-telemetry | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-kyma-integration-k3d-telemetry |
| pull-directory-size-exporter-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-directory-size-exporter-unit-test |
| pull-application-operator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-application-operator-unit-test |
| pull-central-application-gateway-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-central-application-gateway-unit-test |
| pull-central-application-connectivity-validator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-central-application-connectivity-validator-unit-test |
| pull-telemetry-operator-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-telemetry-operator-unit-test |
| pull-compass-runtime-agent-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-compass-runtime-agent-unit-test |
| pull-function-controller-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-controller-unit-test |
| pull-function-jobinit-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-jobinit-build |
| pull-function-webhook-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-webhook-build |
| pull-event-publisher-proxy-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-event-publisher-proxy-unit-test |
| pull-eventing-controller-unit-test | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-eventing-controller-unit-test |
| pull-kyma-pjtester | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-kyma-pjtester |
| pull-webhook-cert-init-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-webhook-cert-init-build |
| pull-function-runtimes-python39-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-python39-build |
| pull-function-runtimes-nodejs16-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-nodejs16-build |
| pull-function-runtimes-nodejs14-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-nodejs14-build |
| pull-function-java11-jvm-alpha-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-java11-jvm-alpha-build |
| pull-function-registry-gc-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-registry-gc-build |
| pull-function-java17-jvm-alpha-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-java17-jvm-alpha-build |
| pull-function-runtimes-nodejs18-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-nodejs18-build |
| pull-kyma-pjconfigtest | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-kyma-pjconfigtest |
| pull-function-runtimes-nodejs-v16-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-nodejs-v16-build |
| pull-function-runtimes-nodejs-v18-build | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-function-runtimes-nodejs-v18-build |
| pre-main-serverless-integration-k3s | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-serverless-integration-k3s |
| pre-main-kyma-gardener-gcp-goats-api-gateway | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pre-main-kyma-gardener-gcp-goats-api-gateway |
| pull-kyma-crd-governance | 754dabb4b4f499b331afe040e69c995d10970a63 | link | true | /test pull-kyma-crd-governance |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.