kyma icon indicating copy to clipboard operation
kyma copied to clipboard

Implement code/testing guidelines

Open nachtmaar opened this issue 2 years ago • 2 comments

Description

As a follow-up of defining the code/test guidelines we need to follow the guidelines in the code and tests.

Acceptance Criteria

  • Code and tests are following strictly the guidelines

Subtasks:

  • [ ] Follow GWT pattern
  • [ ] Use Functional Options Pattern
  • [ ] Follow naming scheme for table-driven tests: name/given/want

Migration of recommended libraries:

  • [ ] #13565
  • [ ] #13561
  • [ ] #13564
  • [ ] #13560

Reasons

Code and testing Guidelines are supposed to help us by agreeing on a common set of rules. However, they are only worth something then we also follow them.

  • For new code they are already in place.
  • Old code will be migrated as part of this epic.

Attachments

nachtmaar avatar Mar 07 '22 10:03 nachtmaar

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

kyma-stale-bot[bot] avatar May 16 '22 15:05 kyma-stale-bot[bot]

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 02 '22 03:08 github-actions[bot]