kylo252
kylo252
> Cloning would make the build artifacts non-deterministic and Homebrew compares against a shasum. See [Homebrew/homebrew-core#132446](https://github.com/Homebrew/homebrew-core/pull/132446) for more context. Specifically [this comment](https://github.com/Homebrew/homebrew-core/pull/132446/files#r1212718069). @osalbahr, thanks for adding more context! I'm still...
> I could probably make this pr quite a bit smaller. the build step would stay here, that would leave 151 loc (7 files 2 of which are icons) in...
> I can agree with all the packaging stuff begin in a separate repo. just the build cmake would stay in the core, it makes packaging for others way easier...
> I tried to do that, and it seems like a pain because you'd need to access paths outside of the cmake project, but i'll do a bit more research...
@LostNeophyte, I actually figured out a pretty simple solution that will, hopefully, satisfy everyone! 1. move the cmake files into `utils/packaging` 2. add appropriate `make` rules that will copy `CMakeLists.txt`...
> Sounds good to me, do I still put the ci workflow, appimage script and CPack in the lvim-mono repo? no, that's fine since it goes into `.github/`. however, we...
sorry for the delay, we should preferably handle the deprecation gracefully.
> Hey @kylo252! no worries, all good. What do you mean by that? Is there a way to do that? check the deprecation handler: https://github.com/LunarVim/LunarVim/blob/master/lua%2Flvim%2Fconfig%2F_deprecated.lua#L20
> This also increases the minimal Neovim version to 0.9.4. I just noticed that this requires a version bump
I simplified the process: The changes are internal to the setup function, and no further action is required from the user. All the options under `lvim.builtin.treesitter.context_commentstring` will be directly passed...