jvm.js icon indicating copy to clipboard operation
jvm.js copied to clipboard

Writing of transformed class files

Open kylestev opened this issue 9 years ago • 4 comments

  • [ ] Methods for writing general class file. Possible refactoring options include the following:
    • [x] NodeBuffer needs a way to write bytes to a buffer
    • [ ] Clean-up ClassFile to have methods like read/write that accept a buffer and read/write to them accordingly
    • [ ] Some sort of FieldNode/FieldInfo class which can handle the writing of its data
    • [ ] Some sort of MethodNode/MethodInfo class which can handle the writing of its data (including writing of bytecode, though that can be handed off to the instruction classes themselves)
    • [ ] Some sort of AttributeNode/AttributeInfo class which can handle the writing of its data
  • [x] Specific methods for writing bytecode back to a buffer. This should be made easier by @TSedlar's inheritance model for bytecode instructions.

kylestev avatar Nov 01 '15 11:11 kylestev

@TSedlar for now, just use the buffer class for writing data back to a buffer. in the future we might fork binary-parser to allow for code generated binary writers. if you feel like creating some PRs for the refactoring/implementation of (Field|Method)(Node|Info) go for it.

kylestev avatar Nov 01 '15 11:11 kylestev

@TSedlar if you want to reference this issue in your commits put refs #8 inside of your commit body (not the commit header/title) as I don't expect this to be done in a single commit. I'll contribute to this issue as well if you want to get started with implementing the write method on the children of AbstractInstruction

See here under Issue references within a repository

kylestev avatar Nov 01 '15 11:11 kylestev

related to #1

kylestev avatar Nov 01 '15 11:11 kylestev

Marking this for a future milestone. Probably v0.3.

kylestev avatar Nov 07 '15 22:11 kylestev