ofxCv icon indicating copy to clipboard operation
ofxCv copied to clipboard

Morphological thinnig algorithm bug

Open roymacdonald opened this issue 8 years ago • 1 comments

Hi Kyle, hope you're doing well. I found a bug in the morphological thinning algo. Check this screenshot screen shot 2016-01-19 at 15 00 33

Probably when using it on images with thin lines it might work but as you can see when lines are wider it doesn't behave well. What's going on is that the thinning is being done over the original image, thus the evaluation for each pixel is being done over the already modified image generating a wrong evaluation. The fix is quite simple, just create a copy of the original image that's used for evaluation and modify the original. I have this fix already made. Should I PR? best

roymacdonald avatar Jan 19 '16 18:01 roymacdonald

absolutely! please make a PR!

kylemcdonald avatar Jan 24 '16 23:01 kylemcdonald