docker-aosp icon indicating copy to clipboard operation
docker-aosp copied to clipboard

[6.0-marshmallow branch] add gosu; refactor things

Open robbyoconnor opened this issue 6 years ago • 5 comments

This will also fix issues with the ccache env vars not showing up -- at least in my testing.

robbyoconnor avatar Jul 18 '17 08:07 robbyoconnor

aosp@2d3c9b0ff45d:/aosp$ env 
HOSTNAME=2d3c9b0ff45d
TERM=xterm
CCACHE_DIR=/tmp/ccache
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/aosp
HOME=/home/aosp
SHLVL=1
GOSU_VERSION=1.10
USE_CCACHE=1
_=/usr/bin/env
aosp@2d3c9b0ff45d:/aosp$     

robbyoconnor avatar Jul 18 '17 08:07 robbyoconnor

Fixed a small issue and rebased

robbyoconnor avatar Jul 18 '17 16:07 robbyoconnor

you jus see the process, not a forked process

robbyoconnor avatar Jul 18 '17 17:07 robbyoconnor

that said, hold off on merging this...wanna see if I can fix a small issue...there's a weird issue where I'm seeing an unmet dependency error related to openjdk and wanna fix that

robbyoconnor avatar Jul 18 '17 17:07 robbyoconnor

@kylemanna -- this is ready for showtime -- I think we should use gosu -- the rationale behind why it exists is good -- as well as the fact that it just gets out of the way vs what sudo su, etc do.

Ultimately -- this up to you -- I'm just contributing back my changes :)

robbyoconnor avatar Jul 19 '17 02:07 robbyoconnor