The-Documentation-Compendium icon indicating copy to clipboard operation
The-Documentation-Compendium copied to clipboard

CONTRIBUTING.md should not be a git tutorial

Open meowsbits opened this issue 5 years ago • 5 comments

https://github.com/kylelobo/The-Documentation-Compendium/blob/d472f574099bf4fec09c2a843857a9b10dc0a40f/CONTRIBUTING.md

This is tutorial on how to use git. This has nothing to do with real-world project contribution guidelines that would be useful in the context of a working git project. There are far better "How to use git" tutorials out there, and this space should describe either

  • how to actually contribute to this repo, or
  • in general, a proposed education around the politics and conventions of contributing at large

meowsbits avatar Jun 06 '19 00:06 meowsbits

Thanks for the feedback. Would you advocate this format?

  1. Fork it (https://github.com/kylelobo/The-Documentation-Compendium/fork)
  2. Create your feature branch (git checkout -b feature/fooBar)
  3. Commit your changes (git commit -am 'Add some fooBar')
  4. Push to the branch (git push origin feature/fooBar)
  5. Create a new Pull Request

race2infinity avatar Jun 06 '19 00:06 race2infinity

Nope. That is also a git tutorial.

meowsbits avatar Jun 09 '19 00:06 meowsbits

Maybe look for contributing README and pages of Apache projects. They are usually well made. https://github.com/apache/spark/blob/master/CONTRIBUTING.md https://spark.apache.org/contributing.html

cyrilou242 avatar Jun 09 '19 19:06 cyrilou242

Hi @kylelobo, I see that there's no longer a CONTRIBUTING.md file. May I ask why, and if I can create a new issue and be assigned to the issue?

LuluNwenyi avatar Jan 09 '22 10:01 LuluNwenyi

The CONTRIBUTING.md file is still there

race2infinity avatar Jan 09 '22 18:01 race2infinity