Mockingjay icon indicating copy to clipboard operation
Mockingjay copied to clipboard

Check if Mockingjay include Mockingjay-Swift.h !

Open MedAmineWinners opened this issue 6 years ago • 2 comments

@kylef
For pod files that do not use use_frameworks!, testing with Mockingjay returns a build error!

<Mockingjay/Mockingjay-Swift.h> file not found

So it will be better for you to add something like this in your MockingjayURLConfiguration.m to check if include /Mockingjay-Swift.h or not.

this will make life easier for developers who use your pod to unit test their frameworks. I tried to make a ullRequest on it, but it's not possible for me like I don't have the rights

#if __has_include("Mockingjay-Swift.h")
    #import "Mockingjay-Swift.h"
#else
    #import <Mockingjay-Swift.h/Mockingjay-Swift.h>
#endif

MedAmineWinners avatar Feb 22 '19 11:02 MedAmineWinners

@kylef Please apply those changes, it works with them.

mihailsalari avatar Mar 18 '19 09:03 mihailsalari

@kylef I have the same problem, any idea when you can manage to merge this? We love Mockingjay here, and hope we can continue to use it. 🤘

fousa avatar Apr 12 '19 08:04 fousa