JSONWebToken.swift icon indicating copy to clipboard operation
JSONWebToken.swift copied to clipboard

Removing CommonCrypto to fix builds in Xcode 10 beta

Open jondwillis opened this issue 6 years ago • 3 comments

See: https://github.com/kylef/JSONWebToken.swift/issues/102

jondwillis avatar Jun 12 '18 18:06 jondwillis

@jondwillis Can you rework this PR so it works on the current version of Xcode too?

kylef avatar Jun 12 '18 19:06 kylef

I have a fix in #112 for this issue that works across both Swift 4.1.x and Swift 4.2. Earlier versions of Swift aren’t supported because #if canImport(ModuleName) was added in Swift 4.1.

I tried some other ways to get it working on earlier Swift versions and could not get them working reliably, but a better way may exist and I frankly didn’t invest too much time into it. In any case, feel free to borrow the fix if needed.

jonblatho avatar Jul 29 '18 04:07 jonblatho

@kylef According to an Apple news from September 2018, this month of March 2019 will see Xcode 10 being mandatory for publishing iOS apps. And Xcode 10 supports Swift 4.x and #if canImport(), so there is really no need to keep support for older versions of Xcode.

Coeur avatar Mar 12 '19 01:03 Coeur