Kyle Carberry
Kyle Carberry
@spf13 anything blocking this? It'd be quite helpful in my tests!
@bradfitz I fixed this up to use a channel. It's not the simplest code to follow, but I didn't want to pass the WaitGroup to a child func. Happy to...
@bradfitz friendly ping! Happy to make any changes necessary; I'm trying to get rid of our fork :)
No biggie! Our fork is really minor, so it's trivial to maintain.
@nhooyr thoughts are welcomed!
How are you requiring the module? You shouldn't have to do `writeModule` since you are doing `writeFiles` to the `node_modules` dir.
`writeFiles` on `node_modules` should work. I believe that transformation might be causing some problems. Could you post your `tsconfig.json`? cc: @code-asher
@enobufs I've found a case where this seems to consistently fail. See https://github.com/cdr/coder-cli/pull/368/commits/5ff49026d3118f8647ceaa4c895ba1980a2ed233 If you copy the DataChannel to `io.Discard` on the server-side, the issue never happens. https://github.com/cdr/coder-cli/pull/368/files#diff-62f8c8d3fb7e16200851008a80e52e4c000482ebe616712a6018431924c67866R333 Running tests...
I've isolated it further in this commit: https://github.com/cdr/coder-cli/pull/368/commits/0dc0e56cfef10b2b1cb85603c2da7cd7e6a42a47 Uncomment the following line, and it works as expected: https://github.com/cdr/coder-cli/pull/368/commits/0dc0e56cfef10b2b1cb85603c2da7cd7e6a42a47#diff-34c91981f059bb5d86d78bb53990a009247009fcfc946b00884b03f5c1a63d55R95 My assumption is there's a race condition somewhere when we write a...
This should be routed by the normal frontend app, not a separate HTML file.