Kyle Liberti

Results 49 comments of Kyle Liberti

> The Secret is not used directly, so I think there is no expectation that it would roll Cruise Control just because you changed the Secret name or key. I...

Thank you for the reproducer @egyedt, using your directions I was able to reproduce the issue and find the problem. There is a bug in the code that prevents API...

It's all yours if you want it @OwenCorrigan76, feel free to assign it to yourself.

> we in general, want to mirror the Kube API and that is IMHO a free string without any restrictions. If there's a specific reason we or the Kubernetes team...

> I'm not sure what exactly you mean by hardcoded here. What I mean by "hardcoded" is that condition types like "Ready" and "Warning" are written directly as literal String...

> I do not see any excesive use of it in the code. Sure, there are many tests checking the condition. But it is their point to check the right...

> Thanks for the response. I think fixing forward is probably better than revert this PR at this moment. Let's do it. Hi @CCisGG, would it be possible to isolate...

> That Cruise Control and Cruise Control metrics reporter need some minimal values to work properly (@kyguy will try to provide some values needed by Cruise Control) Sorry I dropped...

> That Cruise Control and Cruise Control metrics reporter need some minimal values to work properly (@kyguy will try to provide some values needed by Cruise Control) Apologies for the...