tree-of-thoughts icon indicating copy to clipboard operation
tree-of-thoughts copied to clipboard

tot_dfs() got an unexpected keyword argument 'confidence_threshold'

Open claudiobottari opened this issue 1 year ago • 2 comments

Getting few errors likes this, should I fix it?

tree-of-thoughts\tree_of_thoughts\treeofthoughts.py", line 45, in solve result = self.tot_dfs(initial_prompt, num_thoughts, max_steps, value_threshold, TypeError: tot_dfs() got an unexpected keyword argument 'confidence_threshold'

claudiobottari avatar May 30 '23 14:05 claudiobottari

@claudiobottari I have got bunch of those, too :( Basically self.tot_dfs and self.tot_bfs have a set of different arguments and no unified wrapper around them, so I edited the TreeofThoughts class source file in my conda environment

@kyegomez some points:

  • there are some misspellings here - "inital -> initial"
  • what do you think about wring one traversal method, which will incapsulate the run of either DFS or BFS under the hood, so that the issue of different args is solved?

ivanzhovannik avatar May 30 '23 15:05 ivanzhovannik

Yeah changed 1, can you go deeper on number 2? @ivanzhovannik

kyegomez avatar May 30 '23 18:05 kyegomez