capsule-render icon indicating copy to clipboard operation
capsule-render copied to clipboard

Issues with a custom plugin not returning results

Open johnSchnake opened this issue 2 years ago • 3 comments

See https://kubernetes.slack.com/archives/C6L3G051C/p1655103763401889?thread_ts=1653988487.029769&cid=C6L3G051C

Problem getting results from a custom plugin.

johnSchnake avatar Jul 26 '22 17:07 johnSchnake

I think the issue is that the done file being written is a directory and not a file. Typically what happens when you want the whole directory is that you tar up the directory and then write the tarfile name as the results.

I think this is a pretty simple enhancement to make though and support listing the directory itself. It would make things more simple for users too.

johnSchnake avatar Jul 27 '22 17:07 johnSchnake

A second issue is that the worker says its waiting for some period of time to allow you to alter the donefile/results.

However, it doesnt seem to re-read the donefile. I tried editing the donefile to point to the junit file and the directory is still being used as the 'results file' instead of the new value.

I'll file a separate issue for that.

johnSchnake avatar Jul 27 '22 17:07 johnSchnake

Confirmed this is the issue in code and in practice; I added a sidecar that would remove the done file and keep it 'missing' for long enough for the sonobuoy-worker to reread it and things worked as expected.

johnSchnake avatar Jul 27 '22 17:07 johnSchnake

Thanks John, uploading directory works awesome

oshoval avatar Aug 16 '22 07:08 oshoval