capsule-render icon indicating copy to clipboard operation
capsule-render copied to clipboard

Can we adjust the e2e timeout per-test?

Open johnSchnake opened this issue 3 years ago • 3 comments

If I have a test that normally passes in 5s or less, and it is taking 30s+ I would like it to just timeout and fail. Is this possible?

I know the e2e suite itself can have a timeout, that Sonobuoy has its own timeout, but what about a per-test timeout?

I think lots of tests upstream will just "wait for X" and it defaults to waiting for 5m.

Specifically in the context of conformance-lite mode, the happy path takes only 6m for ALL the tests to run. If 20% of the tests have timeouts/failures though it can take an hour+ though.

johnSchnake avatar Jan 27 '22 20:01 johnSchnake

https://github.com/onsi/ginkgo/issues/897

johnSchnake avatar Feb 01 '22 21:02 johnSchnake

Based on the discussion in that linked ticket, the upstream k8s code needs some cleanup. There is already a way to customize timeouts but it hasn't been fully implemented throughout the codebase.

Some timeouts here are still used despite being deprecated: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/util.go#L87-L154

For instance, even on the quick mode test we run, it uses the deprecated timeout which cant be configured (and another timeout just hardcoded below that): https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/node/pods.go#L292-L295

I'm going to create an upstream issue to update these and spend some time helping on that issue. It will be time before everyone benefits from those, but it will be a benefit.

johnSchnake avatar Feb 04 '22 19:02 johnSchnake

There has not been much activity here. We'll be closing this issue if there are no follow-ups within 15 days.

stale[bot] avatar Aug 10 '22 02:08 stale[bot]