RNParallax icon indicating copy to clipboard operation
RNParallax copied to clipboard

Adds typescript types

Open ajmath opened this issue 6 years ago • 4 comments

If you're interested in adding some validation for the types, I can help set that up but it would require adding react, react-native, and typescript as dev dependencies which I didn't want to do since there are none currently. Basically, add those dependencies and then add an npm script with npx tsc --noEmit ./index.d.ts.

ajmath avatar Feb 07 '19 14:02 ajmath

hi @ajmath thanks for the suggestion.. but I not so understand on how it works 😢 (no TS experience)

kyaroru avatar Feb 08 '19 13:02 kyaroru

That's all fine, it's mergeable as is now. Just something to consider for the future if you start adding some CI.

ajmath avatar Feb 08 '19 17:02 ajmath

Much needed PR, otherwise I have to jump to GitHub readme everytime to see the type of value a property expects

Josephdias92 avatar Mar 01 '19 07:03 Josephdias92

@kyaroru do you want to merge this?

jdnichollsc avatar Jul 07 '19 00:07 jdnichollsc