pals icon indicating copy to clipboard operation
pals copied to clipboard

tol palettes

Open mtennekes opened this issue 3 years ago • 2 comments

Hi,

I see a whole series of "tol" palettes in `pals:::syspals:

names(pals:::syspals)[substr(names(pals:::syspals), 1, 3) == "tol"]
 [1] "tol"               "tol.bright"        "tol.highcontrast"  "tol.vibrant"       "tol.muted"         "tol.dark"          "tol.light"        
 [8] "tol.sunset"        "tol.burd"          "tol.prgn"          "tol.ylorbr"        "tol.iridescent"    "tol.smoothrainbow"

but there are no functions to retrieve them (except for "tol", "tol.groundcover", and "tol.rainbow"). Can you also export the others too? .

mtennekes avatar Jun 16 '21 15:06 mtennekes

I think I had decided not to include these palettes because they were so similar to other palettes and I tried not to include too many palettes because it increases the burden of maintaining extra code and documentation. I suppose I should remove these from syspals.

Here are the ones that you mention. Do you see any palettes that are distinct enough to make a worthwhile contribution to the existing set of palettes?

tol_additional_palettes

Compare to the existing palettes https://github.com/kwstat/pals/blob/master/man/figures/pals_catalog.png

Here are some similarities (not comprehensive) between the proposed palettes with existing palettes.

tol.bright = tol
tol.burd = brewer.rdbu
tol.prgn =  brewer.prgn
tol.ylorbr = brewer.ylorbr

kwstat avatar Jun 17 '21 16:06 kwstat

Thanks, I've been told that these palettes work great for people with color blindness. If so, I would suggest to keep them, even though some are similar to brewer. It is nice to have one family of palettes that are suitable for colorblind people. I needed, I can make a pull request.

mtennekes avatar Jun 19 '21 20:06 mtennekes