pkNX icon indicating copy to clipboard operation
pkNX copied to clipboard

Setting InheritAbilitySetting to All still randomize the abilities

Open Salier13 opened this issue 3 years ago • 0 comments

image image image image

Despite setting the parameter InheritAbilitySetting to All, no abilities are inherited through evolution. This parameter does work when set to One or Two. The Shared value isn't clear on its differences with the All value but doesn't keep all 3 abilities through inheritence either.

Seeing the code it seems the options are kinda opposite of their descriptions, still no information on what Shared is supposed to do. https://github.com/kwsch/pkNX/blob/fe9e21749fa548f5efbf150867b6373bdd30ca99/pkNX.Randomization/Randomizers/Personal/PersonalRandomizer.cs#L233-L253

After further analysis this seems to be caused by the SameAbilityChance setting overwriting the abilities even in the case of an inheritence, which doesn't seems to be a wanted comportment. I will be submiting a fix this evening assuming that the comportment of the All value is truly the one desired even if opposed to its description.

Salier13 avatar Jul 27 '22 15:07 Salier13