pk3DS icon indicating copy to clipboard operation
pk3DS copied to clipboard

No Fixed Damage + Use Levelup Only bugs

Open sora10pls opened this issue 7 years ago • 1 comments

Get Current Levelup Moves (XYORAS)

-snip- Fixed!

Sanitation of Moves

Instead of giving duplicate terrible moves as you've once said, it instead gives the PKM moves it doesn't even get in its levelup. Unlike RSTE, SMTE properly populates moves even if at least 1 is invalid (no slots are empty/frozen).

Gabite with Peck: image Garchomp with Water Gun and Thunder Shock: image image

sora10pls avatar Oct 17 '17 17:10 sora10pls

More like a 'pk3DS's scope doesn't cover these cases'

RSTE: If the user doesn't modify moves, the game auto-populates based on the learnset. RSTE doesn't override the movepools if it is not told to (ie it doesn't do the advanced move options like SMTE).

SMTE: Rather than having an empty move slot, pk3DS just sets it to a random low powered move.

The path to resolve these limitations is as follows:

  • Use learnset randomization in the event that moves are banned (RSTE).
  • Add learnset override for getCurrentMoves that provides a banlist and returns getMoves(level).Reverse().Where(z => !Banlist.Contains(z)).Take(4).Reverse().ToArray();
  • Use the override for fetching moves for all cases (banlist being empty is ok).

kwsch avatar Oct 17 '17 18:10 kwsch