NHSE icon indicating copy to clipboard operation
NHSE copied to clipboard

Name change issue

Open Chees3y opened this issue 3 years ago • 9 comments

Hello! I downloaded the latest build of NHSE and used it to edit the name of my villager, however, the letters in-game are still sent from my old name and the villagers treat me like a brand-new person. Is there a way to fix this?

Chees3y avatar Dec 29 '20 18:12 Chees3y

Changing the player's name runs a bytewise replacement throughout all of the loaded savefile-parts.

https://github.com/kwsch/NHSE/blob/83169b87383a070278e0d7773b8f803b748360b9/NHSE.WinForms/Editor.cs#L331-L336

If the mail/villagers are comparing things differently, then things will need to be documented on how they need to be updated, prior to being able to be implemented in NHSE.

kwsch avatar Dec 29 '20 18:12 kwsch

Is this something I can go in and fix later? Or is my save kinda fucked?

Chees3y avatar Dec 30 '20 21:12 Chees3y

You can always change it back to your original name, or reuse the same backup.

You can also try hex editing the decrypted save files to do a byteswap (with 00 padded to match the same length) with the unicode strings you want to replace.

I did the identity-replace (which is a u64+string byte pattern) rather than just a string-replace, because some people can enter really dumb names (short) that may be present elsewhere in the save but not stored as a string value.

Example:

Player name is "H", wants to replace with "Herman"

Replace: 48 00 00 00 00 00 00 00 00 00 00
With:    48 00 65 00 72 00 6D 00 61 00 6E

This becomes problematic if:

Player name is "H", wants to replace with "J"

Replace: 48 00
With:    49 00

Doing the ^ replacement will likely hit other regions that weren't storing the players name, and just so happened to have the same value. So it's something to be careful of.

kwsch avatar Dec 31 '20 00:12 kwsch

You can manually update a villager's player name/island name memory string as of b97082c95dc9b64133c9c90fd8d551e38930d154. Identities will not update, but this should be enough if all you've done is changed your name in NHSE.

The postbox editing is a whole other can of worms.

berichan avatar Feb 07 '21 15:02 berichan

Am I reading this issue correctly, that there isn't a way to change your name, at least in a way where you don't see your old name in game anymore (in new content)?

LauraWebdev avatar Mar 17 '21 17:03 LauraWebdev

I've discovered that a villager's personal.dat in decrypted dumps contains a line that seems to be the mail's signature line starting at 0x00041BD8 (please someone confirm if this is a static offset).

Just go search for 46 00 72 00 6F 00 6D in a hex editor to find the "From".

image image

But since that is an English string there, maybe switching to a different language (Switch settings) and back would also solve this without having to hack this in, at least for now 🤔

cactysman avatar Dec 20 '21 13:12 cactysman

@cactysman 0x36a50 (GSavePlayerOther) + 0xb188 (GSaveMailUserInfo) = 0x41BD8, which is the offset you found, so I would assume it is right.

hp3721 avatar Dec 20 '21 17:12 hp3721

How can I change my villagers name on animal crossing new Horizon

Maryjoanna25 avatar Sep 09 '22 15:09 Maryjoanna25

Hey, I'm trying NHSE for the first time and I'm mainly concerned with the issue of villagers treating me like a new person. I'm speaking from experience using the latest release as of this comment. Is there a workaround for this?

Gamerguy2234 avatar Aug 17 '23 17:08 Gamerguy2234