ansible-role-yedit icon indicating copy to clipboard operation
ansible-role-yedit copied to clipboard

Published 20 hours ago • verified publisher icon kwoodson

Python2.6 format fields

Open juliusliunz opened this issue 6 years ago • 2 comments

I fixed the bug #40 by specifying the positional arguments for all occurrences of *.format(. Also replaced the %s placeholder with {0} in line 204.

juliusliunz avatar Apr 20 '18 04:04 juliusliunz

@juliusliunz, please let me know if this is still required. I updated the module to encompass this work. If not, please update and we'll get it merged.

kwoodson avatar May 18 '18 13:05 kwoodson

Just including my comment from #40 here, as it is closed and might not be seen:

@kwoodson Ok I tried some monkey patching of my local copy of the role - it looks like these two changes are missing:

https://github.com/kwoodson/ansible-role-yedit/pull/41/files#diff-1247c9a5559be75581ce8356c0e51c58L204 (lines 204 & 205)

After patching those, I'm able to run this on a CentOS6 server with Python 2.6.6, without the zero length field name in format error.

So that would imply that most of @kwoodson's updates to the module have fixed the Python 2.6 issue, with the exception of those two lines from this PR, which would still need to be applied.

tdmalone avatar Oct 13 '18 11:10 tdmalone