purescript-halogen-svg icon indicating copy to clipboard operation
purescript-halogen-svg copied to clipboard

Add CSS font-size property (by kettlebell)

Open epost opened this issue 5 years ago • 9 comments

This enhancement was made by kettlebell: https://github.com/kettlebell/purescript-halogen-svg/commit/d6d96caa5f43abfedde511dc7a30b2f38558f865.

epost avatar May 15 '19 14:05 epost

FYI @kettlebell, I made a PR out of your contribution.

epost avatar May 15 '19 14:05 epost

Hi @epost, thanks for arranging the pull request. I've recently returned to my repo and updated it to use Spago and Halogen 5 (wasn't too bad as you can see here)

Also it'd be great to flesh out some more of the SVG properties.

kettlebell avatar May 16 '19 13:05 kettlebell

@kettlebell That's good to hear! I'm doing this in the hopes of converging on a repo that can be maintained, because we're using this at Statebox and I've added a fair number of features, including animation support. Here is a WIP document describing the current state of affairs: https://hackmd.io/lYvFcjb7STe2YzIet9sM7w?both. I've added the changes you just mentioned to the document.

@kwohlfahrt Would you consider making some of us contributors, so we can collaborate on maintenance tasks?

epost avatar May 16 '19 14:05 epost

@epost I've started using this repo and I've added a couple of small things here https://github.com/kwohlfahrt/purescript-halogen-svg/pull/14 (it looks like I've duplicated the marker functionality, woops).

If you have another repo for merging various changes I'll happily create a PR there :)

rskew avatar Aug 23 '19 16:08 rskew

Hey @rskew, that is cool stuff! :D And a coincidence too; Sjoerd Visscher just started working on this yesterday at https://github.com/statebox/purescript-halogen-svg. Would be great if you could make a PR.

epost avatar Aug 23 '19 21:08 epost

Cheers @epost. I'll aim to make a PR soon, I'll have to update my parent project from Halogen 4 to 5 first.

rskew avatar Aug 24 '19 09:08 rskew

@epost @rskew - sorry for the long silence. As you guys can see, I'm no longer doing any purescript development so I don't have any personal use for this library. Would you prefer to be collaborators here, or alternatively I can replace it with a placeholder redirecting to another repo.

kwohlfahrt avatar Nov 06 '19 19:11 kwohlfahrt

@kwohlfahrt all good :) I'm up for whatever.

rskew avatar Nov 11 '19 12:11 rskew

@kwohlfahrt hi, could you add me as a maintainer, I want to merge all currently open PRs and update to the latest halogen

I want to use this repo in https://github.com/srghma/purescript-halogen-nextjs

srghma avatar Jul 31 '20 14:07 srghma