docker-registry-frontend icon indicating copy to clipboard operation
docker-registry-frontend copied to clipboard

routes generated in repo listing do not match app.routes

Open Morriz opened this issue 8 years ago • 4 comments

How can href="repository/{{repo.name}}" in repository-list.html match with these routes:

      when('/home', {
        templateUrl: 'home.html',
        controller: 'HomeController',
      }).
      when('/repositories/:reposPerPage?/:lastNamespace?/:lastRepository?', {
        templateUrl: 'repository/repository-list.html',
        controller: 'RepositoryListController'
      }).
      when('/repository/:repositoryUser/:repositoryName', {
        templateUrl: 'repository/repository-detail.html',
        controller: 'RepositoryDetailController',
      }).
      when('/repository/:repositoryUser/:repositoryName/tags/:searchName?', {
        templateUrl: 'repository/repository-detail.html',
        controller: 'RepositoryController',
      }).
        when('/about', {
        templateUrl: 'about.html',
      }).
      when('/tag/:repositoryUser/:repositoryName/:tagName/:imageId', {
        templateUrl: 'tag/tag-detail.html',
        controller: 'TagController',
      }).
      when('/image/:imageId', {
        templateUrl: 'tag/image-detail.html',
        controller: 'ImageController',
      }).
      when('/image/:imageId/tag/:repositoryUser?/:repositoryName?', {
        templateUrl: 'tag/create-tag.html',
        controller: 'CreateTagController',
      }).
      otherwise({
        redirectTo: '/home'
      });

The app always jumps to /home because of this...or am I missing something here?

Morriz avatar Mar 24 '16 18:03 Morriz

No, you are correct and it's broken. If you supply a pull request, or make a patch publicly available - a lot of people will be happy.

FredrikWendt avatar Mar 25 '16 09:03 FredrikWendt

Will do asap!

On 25 mrt. 2016, at 10:42, Fredrik Wendt [email protected] wrote:

No, you are correct and it's broken. If you supply a pull request, or make a patch publicly available - a lot of people will be happy.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

Morriz avatar Mar 25 '16 10:03 Morriz

There are already two PR related to this issue (see #104 and #94). Consider using one of them, if you can give feedback it will be appreciated. :)

arthurdk avatar Mar 25 '16 18:03 arthurdk

Can be closed with #116

Morriz avatar Mar 30 '16 11:03 Morriz