Konrad Windszus

Make builds reproducible by default

1

Currently the plugin parameter `useDependencyVersions` is set to `false` leading to non-reproducible build (as the check is performed against a moving target). To have reproducible builds by default that parameter...

The Cloud Manager build fails (correctly) with ``` 2024-04-08 10:21:55.796 Convert Merge Analyse version [0.5.180] 2024-04-08 10:22:40.977 Analyser warnings have been found 2024-04-08 10:22:40.977 The analyser found the following warnings...

Create analyser which replicates the logic from CQBP-84

3

The Sonar rule described in https://experienceleague.adobe.com/docs/experience-manager-cloud-manager/using/how-to-use/custom-code-quality-rules.html?lang=en#product-apis-annotated-with-providertype-should-not-be-implemented-or-extended-by-customers is currently only executed in Cloud Manager. It would be helpful to check the code for implementation of interfaces marked as "providertype" even locally....

Switch from Plexus to JSR330 annotations

1

As the Plexus annotations are deprecated one should use the JSR 330 ones instead: https://github.com/eclipse/sisu.plexus/wiki/Plexus-to-JSR330.

Some documentation on the module structure format of "aemapp" packaging which can be processed with `package-app` mojo (https://github.com/adobe/aemanalyser-maven-plugin/blob/main/aemanalyser-maven-plugin/src/main/java/com/adobe/aem/analyser/mojos/PackageAppMojo.java) would be really helpful. Particularly interesting are answers for the following questions:...

Check with m-enforcer for complete runtime classpath

13

## Description ## Related Issue ## Motivation and Context ## How Has This Been Tested? ## Screenshots (if appropriate): ## Types of changes - [ ] Bug fix (non-breaking change...

Raise warning to errors once decommissioning of deprecated packages is near

1

There is already a WARNING raised in case a deprecated API is used in the code via the analyser https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/master/src/main/java/org/apache/sling/feature/extension/apiregions/analyser/CheckDeprecatedApi.java. This is often not noticed by developers, so there should...

analyse error: Artifact requires [aem-guides-wknd.core/0.0.6] osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=11))" when compiled with Java 8

11

When you execute `mvn verify` on https://github.com/kwin/aem-analyser-example/tree/analyse-failure-with-java8 with Java 8 you get ``` [ERROR] com.adobe.aem.guides:aem-guides-wknd.core:0.0.6: Artifact com.adobe.aem.guides:aem-guides-wknd.core:0.0.6 requires [aem-guides-wknd.core/0.0.6] osgi.ee; filter:="(&(osgi.ee=JavaSE)(version=11))" in start level 20 but no artifact is providing...

Provide Maven Site

1

A Maven generated Plugin Site would be beneficial because it automatically documents all goals and its parameters in a standard way. The result could be hosted e.g with Github Pages.

The method [`StringUtils.capitalize(String)`](https://commons.apache.org/proper/commons-lang/javadocs/api-3.3/org/apache/commons/lang3/StringUtils.html#capitalize(java.lang.String)) should be exposed via EL as well (https://github.com/Netcentric/accesscontroltool/blob/develop/docs/AdvancedFeatures.md#expressions). This is sometimes helpful to reuse the same variable both for a name (usually all lowercase) and label/title (usually...