Konrad Windszus
Konrad Windszus
Is there somewhere an overview of which annotations are recognized by japicmp?
Why not leveraging https://sling.apache.org/documentation/bundles/rendering-content-default-get-servlets.html#streamrendererservlet via request dispatching?
@joerghoh Please read both documentation and code more thoroughly. That streamrendererservlet does the redirect exactly as you implemented (despite its name): https://github.com/apache/sling-org-apache-sling-servlets-get/blob/507a84c5cc2ede84710dd719f97bb483629b969e/src/main/java/org/apache/sling/servlets/get/impl/helpers/StreamRenderer.java#L159
To me the URI being generated in https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/15bfe9a6281618e5f14419c3979194cb5d0148f0/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/BinaryDownloadUriProvider.java#L111 and exposed via `ExternalizedInputStream` look pretty much the same as what is done in https://github.com/adobe/aem-core-wcm-components/pull/2871/files#diff-7c9529fe2217ac11ea6e74a0d7e51371fc07d1769d73e11f21f5c1377c7ce376R698.
Sorry, I cannot really comment here. Any solution which keeps the general functionality is fine with me. I wasn’t aware of those implicit signatures.
Isn't the issue only with encoded question marks, i.e. `%3f` (https://httpd.apache.org/docs/2.4/rewrite/flags.html#flag_unsafe_allow_3f)? Who encodes the question mark in the case of redirect manager? It seems that https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/7c88f0de005f80851dac38e5214d328f77a9e16c/bundle/src/main/java/com/adobe/acs/commons/redirects/filter/RedirectFilter.java#L368 does not do any...
There is two similarly named features for redirects in ACS AEM Commons: 1. Redirect Manager: https://adobe-consulting-services.github.io/acs-aem-commons/features/redirect-manager/index.html 2. Redirect Map Manager: https://adobe-consulting-services.github.io/acs-aem-commons/features/redirect-map-manager/index.html Please clarify with which one you are experiencing issues.
As #713 might take some time, why not simply calling `RR.map(...)` on the JSON value in the mean time? Would you accept a PR for that? The least changes would...
@vladbailescu WDYT about a fix which would just call RR.map on https://github.com/adobe/aem-core-wcm-components/blob/345377e9701a6724abc8ddf5a1fc5c3ade85f406/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/Utils.java#L61?
@vladbailescu Isn't this solved in 2.16.0 (https://github.com/adobe/aem-core-wcm-components/blob/2e055f9d4a1777155229dae22d948ce7ec095a42/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/servlets/SearchResultServlet.java#L305)?