Konrad Windszus

Results 602 comments of Konrad Windszus

Both URL and File have a single String constructor, i.e. are covered by the standard handling.

@royteeuwen No, I wasn't aware of that feature. Maybe one more sentence in the readme like how to replicate the script and where to put it would be good.

Looks much better now, I think long term it makes sense to pass the full `ImportOptions` object to the `ArtifactHandler`s and also use that as argument for the `DocViewImporter` constructor,...

Would be nice to cover that in a test case as well. Not only that deletion of properties no longer contained in the package still works but also that nodes...

I have not deliberately changed anything about being more strict with section nesting, I think we should still allow starting with an h2. Could be an unintended side effect of...

I think it is time for an update again. @michael-o Do you take it up or should I take over to bump to latest m-site-p and fluido 2?

I just did, pushed the updated and cross-checked the result. Looks good to me. @slawekjaranowski Would you mind having another look?

Ok found one regression with table headers, they are by default centered and no longer left-aligned: ![Screenshot 2024-11-07 at 17 47 51](https://github.com/user-attachments/assets/1af5b7ef-b301-42fc-869e-48b31d4d6776) This seems to have regressed with https://github.com/apache/maven-fluido-skin/commit/85123d7be9f42c98712ff94e18619095ab284a9f. @michael-o...

> lost anchors with toc at https://maven.apache.org/settings.html The anchor format changed (using uppercase), unfortunately https://github.com/apache/maven-site/blob/e225ba9c417830bea36e03285ec52f8330790d07/content/markdown/settings.md?plain=1#L20 uses no macro but a hardcoded list and relies on implementation details of the anchor...