apicache icon indicating copy to clipboard operation
apicache copied to clipboard

Organize Tests

Open kwhitley opened this issue 6 years ago • 1 comments

I'd like to break the tests apart (the main test file is approaching 1000 lines) in a manner that makes sense, easily readable, etc.

Any help/PR to this effect would be vastly welcomed and warrant a major contribution credit :)

🙏

Requirements:

  • All tests or core code must be written in ES5 compatible JS - as in no arrow functions, imports, etc. As much as it still pains me to have this library+tests written in such outdated syntax, it ensures compatibility and testability on Node all the way back to version 4.0.
  • Any docs/README updates should be written in ES6/ES7+ syntax (not that tests typically need additions to the README)

kwhitley avatar Feb 15 '19 20:02 kwhitley

why write in es5, and not es6/7 with babel? babel will compile the code to es5 and will still be compatible. and you can publish to npm only the es5 built version.

mentaman avatar Mar 04 '19 18:03 mentaman