kwasimensah

Yes, I tried listening to "finish" and "close". Given: ```ts async function myDatabaseMiddleWare(req, res, next) { await databaseQuery1(); await databaseQuery2(); next(); } ``` if server.close is called between databaseQuery1 and...

For tests, I wanted your advice on how you'd like to see an integration-type test i.e. the ability cancel/timeout a request and to make the _serve function more complicated to...

> If these are the only changes, it wouldn't be merged into this module under the current philosophy of our middlewares, where if you can already achieve the thing, we...

> It sounds like you're trying to implement a graceful shutdown system. There are some examples on the Express website: http://expressjs.com/en/advanced/healthcheck-graceful-shutdown.html Those shutdown modules should be providing all the functionality...

> > Terminus and Lightship require an external service to ping your server > > Not that I am aware of. Can you show where that is needed? I use...

> > So if i was just tracking open connections databaseQuery2 wouldn't have taken it's connection out yet so shutdown logic wouldn't see it and think you're down to 0...

> Hi @kwasimensah apologies, I did mess up the example I provided -- that's what I get for trying to write this all up while I'm supposed to be at...

spdx-expression-parse also chokes on the string "BSD" because that's not a valid identifier. See https://github.com/jslicense/spdx-expression-parse.js/issues/11 If you use LicenseWebpackPlugin and use spdx-satisfies as suggested in their documentation pg's dependency on...

was able to get this working by adding this to the bottom of my rails project's test/test_helper.rb ``` ActiveSupport::TestCase.class_eval do alias_method :teardown, :teardown_without_webmock alias_method :after_all_without_webmock, :after_all def after_all_with_webmock after_all_without_webmock WebMock.reset!...

Oh, haven't looked at this in a while. I believe my code still has the monkey patch. Are you asking if it works without that?