kwasimensah

I figured out my actual issue. Both extensions do proxying on equal/equals. If chaiAsPromised isn't last, the proxy from chaiExclude drops information about the subject being a promise. Runkit at...

To clarify, yes, I tried listening to "finish" and "close". Given: ```ts async function myDatabaseMiddleWare(req, res, next) { await databaseQuery1(); await databaseQuery2(); next(); } ``` if server.close is called between...

Actually, format writes to this.version :( I'm hunting down spurious allocations in my project and the call to this.format came up in my debugging. I'm surprised that this function both...

I’m calling compare inside of what’s essentially a tight loop. The allocations are t being JITed away and garbage collection is showing up on my profiling so I’m trying to...

+1 this bug

Adding my two cents, if you have an aspect that wants to make a cc_library type thing next to each target it runs on (like generating code for each proto_library),...

My current version. I deal this would be replaced by serveStatic adding the listeners. ```ts const serveFromDistImages = express.static(path.join(__dirname, "dist", "images"), { immutable: true, index: false, maxAge: 1000 * 60...

The use case I'm trying to catch is when the client aborts. I found in my unit testing it's actually hard to get express/https.server to shutdown cleanly i.e. if the...

So on-finished isn't what I'm looking for because if the client closes the connection in the middle of a request using async middleware "close" will be fired *before* all the...

Moved the thrust of my point to https://github.com/expressjs/express/issues/4356. Coming up with a pull request now