Keith Wansbrough

Results 64 comments of Keith Wansbrough

I think this is superseded by Tokio futures/streams; see [futures crate](https://crates.io/crates/futures), and in particular [the stream module](https://docs.rs/futures/0.1.14/futures/stream/index.html),

> As far as I'm concerned I was happy to read the note about already already-done investigation and potential future evolutions on this topic, as that is something I'd likely...

Thanks :-) On the clippy problem, if you look in https://github.com/diesel-rs/diesel/blob/master/diesel_cli/Cargo.toml#L74C1-L82C29 you see that there's an internal feature `uses_information_schema`, and this is used in https://github.com/diesel-rs/diesel/blob/master/diesel_cli/src/infer_schema_internals/mod.rs#L6C1-L7C24 to control whether the module...

Ah, this is interesting. I was wrong earlier - we do still need `view!` to define the columns of the view, and each column needs a `Table` so that we...

> It's unclear to me why a new `IntoInsertTarget` is useful here if it's only implemented by `Table`. It's not implemented by `Table`, it's explicitly implemented by each `table` that...

> it seems impossible for anything but a `T: Table` to implement the suggested `IntoInsertTarget` trait. I think it could probably be relaxed to `QuerySource`, but today `insert_into` is only...

Cool! Yes, but I think not renaming everything is a win - there's a lot of tricky code that checks for appearances of `Table` etc, which it would be much...

Ah, I'd missed that comment from @weiznich. It does say pretty clearly not to use `Table` for views. But there's a tension here: as we've seen, views _do_ need to...

@waheedullahkhan001 I can't tell from your description - are you seeing some valid video but it keeps being interrupted, or are you just seeing noise?

Yes, that's as far as I got. I've looked at the stream contents and looked at the MP4 specs and cannot figure out what has been done to the video....