colormatic icon indicating copy to clipboard operation
colormatic copied to clipboard

Updated to 1.19.3 and fix some error (not working yet)

Open fedetrifo06 opened this issue 2 years ago • 7 comments

I updated the mod to Minecraft 1.19.3 but i can't compile it for some errors.

Anyone can fix it?

fedetrifo06 avatar Jan 15 '23 19:01 fedetrifo06

I'm afraid that you can't just increment the version numbers and replace the package names; 1.19.3 made major changes to biome registries, which Colormatic uses for customizing colormapping. Updating to 1.19.3 is going to require working around this change.

Rektroth avatar Jan 27 '23 05:01 Rektroth

As it turns out, the preview versions of 1.19.3 OptiFine that are presently available do not currently feature colormapping, likely for this exact reason. Based on what I've seen trying to get it working, it's my opinion that colormapping will have to be completely overhauled.

Rektroth avatar Jan 30 '23 23:01 Rektroth

I'm afraid that you can't just increment the version numbers and replace the package names; 1.19.3 made major changes to biome registries, which Colormatic uses for customizing colormapping. Updating to 1.19.3 is going to require working around this change.

I know, but this is a start

fedetrifo06 avatar Jan 31 '23 20:01 fedetrifo06

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

extremepayne avatar Feb 03 '23 04:02 extremepayne

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

Rektroth avatar Feb 03 '23 04:02 Rektroth

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

Did you ever finish or made progress?

mstreurman avatar Mar 06 '23 14:03 mstreurman

Do these changes allow non-biome related color pack things to be altered? i.e. sky and fog, particles, crops, dyes, xp orbs, etc. If so, could a temporary release (or even forked mod) be released to enable those behaviors for players while we wait on a rewrite of the biome related stuff?

I did try a few days ago, but it seems they're all fairly closely linked together in this mod. By the time I had all the biome functionality removed, very little remained - and what was left still needed refactoring.

But it might still be possible. I might give it another go this weekend when I have more time.

Did you ever finish or made progress?

I haven't actually looked further yet.

Honestly, given some of what we've seen in today's April Fools snapshot, combined with the fact that we have seen Mojang add April Fools features to the game before (see Coal Block snd Stained Glass), I'm hopeful custom colormapping in the vanilla game is coming in the near future. 🫰

Rektroth avatar Apr 02 '23 02:04 Rektroth