valkeyrie
valkeyrie copied to clipboard
kvtools
BadgerDB support
Support for BadgerDB as and alternative to BoltDB based on #22. Open for review and discussion.
https://github.com/dgraph-io/badger
Coverage decreased (-1.8%) to 82.798% when pulling a30360114b067b5d9697aa596f526158c3247e48 on ondrej-smola:master into 61bbc4571a5d3616b996b5b3fc0a04f302d5b340 on abronan:master.
Thanks, I think BadgerDB is the same as BoltDB. First line on project page says "BadgerDB is an embeddable, persistent ..." - i am ok with both ways, choosed *DB to be similar to BoltDB. Will fix ci/readme.
@ondrej-smola Sorry, I missed the mentions with BadgerDB you are right, I'm also ok either way, so let it as is. Thanks
@victorcoder please retry CI check, it seems like it failed due to some internal error
Coverage decreased thus the red but we can still merge it after review (-1.8% seems minor and an artifact of an additional backend being added).
@abronan I am already integrating this project into our solution - will add additional tests when we do some real-world testing and find any problems.
@ondrej-smola Very last step, but would it be possible to squash and rebase the MR on master? We'll be ready to merge then. Thanks!
Hello,
we changed the core system of Valkeyrie: now the stores have dedicated repositories.
So this PR must be converted to a dedicated repository.
To create the repo, you have to use our repository template And if you want to can open a new issue to ask for the transfer of your repository to the kvtools organization.
