valkeyrie icon indicating copy to clipboard operation
valkeyrie copied to clipboard

Aerospike store support

Open n0madic opened this issue 7 years ago • 4 comments

https://aerospike.com/

https://github.com/aerospike/aerospike-client-go

n0madic avatar Nov 06 '18 22:11 n0madic

Coverage Status

Coverage decreased (-0.8%) to 83.397% when pulling 67fd8324e1be5cb2bb0147b7eb30b1e9c7b2b830 on n0madic:master into f2e1850dc90593826b13ea00b36fe630ac15919a on abronan:master.

coveralls avatar Nov 06 '18 22:11 coveralls

Does Aerospike support locking? Adding more stores without locking support, I find it less interesting.

vcastellm avatar Nov 07 '18 10:11 vcastellm

Aerospike supports CAS (safe read-modify-write) operations and the record’s generation to invalidate the write if another updated happened between when you read, and this write operation. I implemented the AtomicPut method in this way.

n0madic avatar Nov 07 '18 20:11 n0madic

@n0madic Thanks a lot for that! I'm going to review that ASAP.

@victorcoder I think adding support for new stores even without Locking is fine as long as users scan the dependency table correctly and are aware of the implications. Thus they have to use the lowest common denominator if they want to use aerospike.

abronan avatar Nov 24 '18 13:11 abronan

Hello,

we changed the core system of Valkeyrie: now the stores have dedicated repositories.

So this PR must be converted to a dedicated repository.

To create the repo, you have to use our repository template And if you want to can open a new issue to ask for the transfer of your repository to the kvtools organization.

ldez avatar Sep 08 '22 15:09 ldez