Austen
Austen
bors r=nvanbenschoten
Noting that this is on Azure: ``` ROACHTEST_cloud=azure ``` Which has had a greater degree of instability in roachtests recently. I'd be pro chalking up to an infra flake.
TYFTR The extended failure(s) are unrelated, probably pre-emption.
Should we merge this @pav-kv? I see the 23.1/.2 backports merged. A failure came in on 24.1 that this patch would have fixed https://github.com/cockroachdb/cockroach/issues/124172
> just wanted to confirm where do we measure the snapshot stream throughput? is it frin the crdb ui console? Thats correct, the replication dashboard page has the snapshot received...
> is there anyways that i can visualize the timer results that might give good indication for bottleneck? You may be able to visualize the timer results by manually pushing...
> From the trace it appears that most of the time is spent on IterateReplicaKeySpans, is it a good direction to dive deep into that iterator to see if there...
> @kvoli - i see that you updated kv.closed_timestamp.propagation_slack to be 0.5s in https://github.com/cockroachdb/cockroach/commit/02f1666fe678fe3879e7a59aee1f9e46cf5b89f1. Do you think using the default of 1s is a way to reduce flakiness, as per...
bors r=nvanbenschoten