KVIrc icon indicating copy to clipboard operation
KVIrc copied to clipboard

Control submenu missing when target is not in channel

Open liny-fox opened this issue 7 years ago • 3 comments

Expected behavior

Right clicking on a nick that is no-longer in the channel should still offer the control submenu for oper commands to be ran.

Actual behavior

Control submenu does not show for nicks that have left the channel but shows for ones still in it.

Steps to reproduce the issue

  1. Right click on someone who has left the channel or server and try to, for example, ban them.
  2. Observe that the control menu is not shown, even when +o in the channel.

System information

KVIrc 4.9.2 'Aria'

Runtime Info:
System name: Windows Release : 10.0.14393
System version: Windows 10 (x64) (Build 14393)
Architecture: Intel64 Family 6 Model 94 Stepping 3
Qt version: 5.5.1
Qt theme: windowsvista

Build Info:
Build date: 2017-04-13 10:59:32 UTC
Sources date: 20170413
Revision number: git-7103-g48fd3bc45
System name: Windows-6.3.9600
CPU name: AMD64
Build command: C:/Program Files (x86)/CMake/bin/cmake.exe
Build flags: 
   MANDIR=share/man
   CMAKE_INSTALL_PREFIX=C:/projects/kvirc/build/release
   Threads=Win32
Compiler name: C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/amd64/cl.exe
Compiler flags: /DWIN32 /D_WINDOWS /W3 /GR /EHsc
Qt version: 5.5.1
Features: IRC, IPv6, Crypt, SSL, IPC, Transparency, Webkit, Perl, Python, Enchant, Qt5, KVS

liny-fox avatar May 18 '17 04:05 liny-fox

What usefulness are you wanting from being able to access said menu after the user leaves the channel? I can't think of any oper specific commands in the command sub-menu.

The only thing in that menu that can still be used after a user leaves the channel is ban. So, even if we allowed for the use of ban after the user leaves the channel, we could only utilize a single ban mask of nick!*@*.

If we allowed for more masks, then we'd have to keep said user in the database for longer than they are visible to the client. With the number of users that come and go on any given day to some popular channels and the length of time that some users leave their clients open, this database could grow rather large, consuming a lot of wasted memory.

IceN9ne avatar May 18 '17 05:05 IceN9ne

Was specifically meaning being able to ban spammers that have come, dropped their spam then left while OPs are away.

Could read the history window to get last address for more masks, but that would be annoying and would look hackish as best, and as for a database for remembering everything, yea, I can see that growing fast.

liny-fox avatar May 18 '17 05:05 liny-fox

What usefulness are you wanting from being able to access said menu after the user leaves the channel? I can't think of any oper specific commands in the command sub-menu.

WHOWAS. Or even just WHOIS if they have left the channel but are still on the server. That way you can request their host/IP without needing to store it somewhere.

Heufneutje avatar May 18 '17 06:05 Heufneutje