KVIrc
KVIrc copied to clipboard
kvirc
kernel: We should read the default config on startup
When kvirc is started it doesn't read the .kvirc4.rc config file. So every time the setup wizard pops up. The patch fixes this.
That fallback is already done here:
https://github.com/kvirc/KVIrc/blob/master/src/kvirc/kernel/KviApplication_setup.cpp#L690-L692
Called from:
https://github.com/kvirc/KVIrc/blob/master/src/kvirc/kernel/KviApplication_setup.cpp#L721
If you keep seeing the setup wizard, the problem might be somewhere else...
I had that with alpha2. If it has already been fixed differently a new alpha release would be nice :)
I am not sure anybody has touched that part of code. Can you try with a git version?
I've tried git master and the setup wizard opens. If I apply my patch, kvirc starts up correctly.
There still are problems with this.
-
We use Hungarian notation for our code, so please don't change the names of the variables.
-
You have changed the config name from "kvirc" to "kvircrc". That's unnecessary and will trigger the setup wizard for all users that update.
-
I don't really know what you mean exactly but I tried to change the names. I think having them consistent through the code makes sense
-
Yes, because this is the KDE convention and this file already exists for file dialog settings
[KFileDialog Settings]
Recent Files[$e]=kvirc_337717_screenshot.png,file:$HOME/.config/KVIrc/tmp/kvirc_337717_screenshot.png
Recent URLs[$e]=file:$HOME/.config/KVIrc/tmp/
Well, all users who update will always get the setup wizard, because it is broken right now. This happened on alpha1 on alpha2 and on master. Not only on one Linux system but on several. I was just tired after several month that this setup wizard always shows up.
Starting kvirc with KF5 support always triggers the setup wizard and the KDE config file is not written so I do not see a problem with that change.
When you use KDE4 the files kvirc creates are:
$ find .kde4/ -name "kvirc*"
.kde4/share/config/kvirc
.kde4/share/config/kvircrc
The first ist the name you specify in the code to point to the kvirc configuration directory. The second is used by file dialogs. When you use kvirc built against KF5 it uses ~/.config and not ~/.kde4 until you copy the file automatically. So you get the setup wizard dialog anyway.
There is not need to have two config files around, that's why I choose kvircrc.
Six years later, sorry, but this seems correct. Please note that this only affects kvirc when built with KDE support. Still, it will force setup to be run for users unless they
cat ~/.config/kvirc >> ~/.config/kvircrc
Adding a small piece of code to migrate the config from the old to the new file would avoid the problem. Will look into it
