kviklet icon indicating copy to clipboard operation
kviklet copied to clipboard

Improve slack message information on query request

Open riupie opened this issue 1 year ago • 1 comments

It would be nice if the Slack message also included the query that will be executed and maybe mention the slack user/group who will review? We can bind the slack id on profile. image

riupie avatar Dec 06 '24 12:12 riupie

Hey riuple, thanks for the feedback. I thought about including the request but decided against it since this can contain sensitive information. If anything I could make this configurable but it seems a bit niche honestly.

Regarding the slack id. Yes I'd love to allow people to connect their accounts more closely. This would potentially also allow checking if a specific user has access to the connection and therefore should be allowed to see the query, this would then even allow approving and denying requests straight out of slack. It's a bit more effort to set this up though so I have to delay that a bit for now. Happy about any contributions though if you happen to have the time to look into it.

Askir avatar Dec 19 '24 23:12 Askir