ktransformers icon indicating copy to clipboard operation
ktransformers copied to clipboard

[feat]: add kunpeng kml support

Open Alisehen opened this issue 1 month ago • 1 comments

Alisehen avatar Nov 13 '25 06:11 Alisehen

Summary of Changes

Hello @Alisehen, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug related to the Kunpeng KML integration, primarily focusing on ensuring the correct build environment setup and refining the MOE (Mixture of Experts) kernel implementation. The changes streamline the KML-specific build process, refactor MOE kernel class names for clarity, and introduce a fix for the scaling logic within the MOE kernel, enhancing its stability and correctness.

Highlights

  • KML Build Configuration: Updated CMakeLists.txt to correctly configure specific GCC/G++ compilers, include directories, and link directories when KTRANSFORMERS_CPU_USE_KML is enabled, ensuring proper integration with the Kunpeng Math Library.
  • MOE Kernel Renaming: Refactored MOE (Mixture of Experts) kernel class names in test_moe_kml.py from KMLInt8_MOE to Int8_KERNEL_MOE and KMLInt4_MOE to Int4_KERNEL_MOE, streamlining naming conventions.
  • MOE Scaling Logic Fix: Modified the apply_scale function in kernel.hpp to introduce an optional jth parameter and adjust the m dimension splitting logic, likely resolving a bug in how scaling is applied across different blocks or ranges.
  • Header Management and Refactoring: Adjusted header includes across several files, including removing operators/kml/moe.hpp from ext_bindings.cpp, adding shared_mem_buffer.h to common.hpp, commenting out float16_t and bfloat16_t type aliases in api/common.h, and updating an include path in batch_gemm_kernels.cpp.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 13 '25 06:11 gemini-code-assist[bot]