ktransformers icon indicating copy to clipboard operation
ktransformers copied to clipboard

fix: add missing CMakeLists.txt for KT-SFT

Open yuxuan-z19 opened this issue 2 months ago • 1 comments

Adds the missing CMakeLists.txt for KT-SFT/csrc/ktransformers_ext (previously ignored due to a .gitignore typo). Tested under the environment from issue #1563.

yuxuan-z19 avatar Nov 08 '25 13:11 yuxuan-z19

Summary of Changes

Hello @yuxuan-z19, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical build issue by fixing a .gitignore entry that was inadvertently excluding a necessary CMakeLists.txt file. It then introduces this newly tracked CMake configuration, which provides a flexible and comprehensive build system for the ktransformers_ext module, supporting a wide array of hardware architectures and acceleration backends. The accompanying install.sh script has also been updated to ensure smooth and correct installation of dependencies and the module itself, leveraging the new build setup.

Highlights

  • CMakeLists.txt Inclusion: Corrected a .gitignore typo to ensure the CMakeLists.txt for KT-SFT/csrc/ktransformers_ext is properly tracked and included in the repository.
  • New Build Configuration: Introduced a comprehensive CMakeLists.txt for ktransformers_ext, enabling robust build configurations for various CPU architectures (ARM, x86 with AVX, AVX2, AVX512, AMX) and GPU backends (CUDA, MUSA, ROCM, XPU, NPU).
  • Installation Script Update: Modified install.sh to use CWD for reliable path resolution and updated dependency installation to requirements-sft.txt and correct module paths.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 08 '25 13:11 gemini-code-assist[bot]

Thank you for your reminder. It was a very effective PR.

JimmyPeilinLi avatar Nov 10 '25 08:11 JimmyPeilinLi