Mooncake icon indicating copy to clipboard operation
Mooncake copied to clipboard

[store] Fix IPv6 link-local address parsing and add IPv6 tests

Open Azure-Tang opened this issue 1 month ago • 3 comments

Description

This PR fixes the IPv6 link-local address support issue reported in #1043. The problem was that IPv6 link-local addresses (e.g., fe80::xxx%interface) could not be properly parsed and used for RPC connections.

Testing

  • add test: ipv6_client_test Link-local test with environment variable: MC_USE_IPV6=1 SERVER_ADDRESS_LL="[fe80::xxx:xxx:xxx:xxx%eno2]:17813"
    ./build/mooncake-store/tests/ipv6_client_test
    --gtest_filter="IPv6ClientTest.BasicPutGetOverLinkLocalIPv6" [ PASSED ] 1 test.

  • Verified mooncake_master can listen on link-local address using netstat -lnp

Type of Change

  • Types
    • [x] Bug fix
    • [ ] New feature
      • [ ] Transfer Engine
      • [ ] Mooncake Store
      • [ ] Mooncake EP
      • [ ] Integration
      • [ ] P2P Store
      • [ ] Python Wheel
    • [ ] Breaking change
    • [ ] CI/CD
    • [ ] Documentation update
    • [ ] Other

How Has This Been Tested?

Checklist

  • [ ] I have performed a self-review of my own code.
  • [ ] I have updated the documentation.
  • [ ] I have added tests to prove my changes are effective.

Azure-Tang avatar Nov 28 '25 06:11 Azure-Tang

Summary of Changes

Hello @Azure-Tang, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing the proper parsing and utilization of IPv6 link-local addresses within the system, which was hindering RPC connections. The core changes involve enhancing the network utility functions to correctly interpret IPv6 addresses with scope IDs and introducing a dedicated, comprehensive test suite to ensure robust IPv6 client functionality across various address formats.

Highlights

  • IPv6 Link-Local Address Parsing Fix: Resolved an issue where IPv6 link-local addresses (e.g., fe80::xxx%interface) could not be properly parsed, preventing their use for RPC connections. The isValidIpV6 and parseHostNameWithPort utility functions have been updated to correctly handle these addresses, including those with scope IDs and optional ports.
  • Comprehensive IPv6 Test Suite: Introduced a new test file, ipv6_client_test.cpp, which includes unit tests for IPv6 address parsing logic and integration tests for basic Put/Get and batch operations over IPv6 loopback and link-local addresses. This significantly improves IPv6 support validation.
  • Dependency Update: The yalantinglibs dependency has been updated from version 0.5.5 to 0.5.6 in dependencies.sh.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 28 '25 06:11 gemini-code-assist[bot]

/gemini review

ykwd avatar Nov 28 '25 07:11 ykwd

@Azure-Tang Could you take a look at Gemini's review?

ykwd avatar Nov 28 '25 07:11 ykwd