kuzzle icon indicating copy to clipboard operation
kuzzle copied to clipboard

Add VirtualIndex to store multiple Kuzzle collection in the same ES index

Open TisserantG opened this issue 2 years ago • 3 comments

What does this PR do ?

Add virtual tenant

How should this be manually tested?

See functionnal test

Other changes

js -> ts for many files

TisserantG avatar Aug 02 '22 14:08 TisserantG

Fails
:no_entry_sign: Found some issues !

Executed Checks

:heavy_check_mark: Branch Merge Check

:x: Changelog Tag Check

Pull Requests must have a changelog:XXX label. If you want to allow this PR to not have a changelog tag, add the following line to the PR body:

ci-no-changelog-tag

:heavy_check_mark: PR Body Check

Generated by :no_entry_sign: dangerJS against a70e1aec66481dede0557f50b6948afd64e10009

kuzzle avatar Aug 16 '22 09:08 kuzzle

Codecov Report

Merging #2375 (6ed64ca) into 2-dev (df27ac0) will decrease coverage by 0.69%. The diff coverage is 51.85%.

:exclamation: Current head 6ed64ca differs from pull request most recent head a70e1ae. Consider uploading reports for the commit a70e1ae to get more accurate results

@@            Coverage Diff             @@
##            2-dev    #2375      +/-   ##
==========================================
- Coverage   91.12%   90.43%   -0.70%     
==========================================
  Files         116      109       -7     
  Lines        8125     6920    -1205     
==========================================
- Hits         7404     6258    -1146     
+ Misses        721      662      -59     
Impacted Files Coverage Δ
lib/api/httpRoutes.js 100.00% <ø> (ø)
lib/cluster/publisher.js 91.52% <0.00%> (-3.22%) :arrow_down:
lib/cluster/subscriber.js 92.81% <20.00%> (-2.46%) :arrow_down:
lib/cluster/node.js 97.10% <42.85%> (-1.13%) :arrow_down:
lib/api/controllers/indexController.js 79.54% <66.66%> (-4.67%) :arrow_down:
lib/core/shared/store.js 71.79% <100.00%> (+0.74%) :arrow_up:
lib/kuzzle/internalIndexHandler.js 100.00% <100.00%> (ø)
lib/service/cache/redis.js 89.15% <100.00%> (ø)
lib/kuzzle/vault.js 30.00% <0.00%> (-55.00%) :arrow_down:
lib/core/storage/clientAdapter.ts
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 31 '22 08:08 codecov[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

sonarqubecloud[bot] avatar Sep 20 '22 14:09 sonarqubecloud[bot]

From what I see there is a lack of support of the m* method (mCreate etc)

Can you add at least 2 functional tests to ensure they are working? One with mCreate and one with any other action (because mCreate have optional IDs while all the other works the same with IDs)

Done

TisserantG avatar Oct 26 '22 09:10 TisserantG

There is also a lack of documentation on this feature

Shiranuit avatar Nov 07 '22 09:11 Shiranuit

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.1% 0.1% Duplication

sonarqubecloud[bot] avatar Nov 09 '22 08:11 sonarqubecloud[bot]

Closed due to inactivity and de-priorized feature

Aschen avatar Dec 29 '22 21:12 Aschen