kuzzle icon indicating copy to clipboard operation
kuzzle copied to clipboard

Upgrade koncorde to 4.0.3

Open Shiranuit opened this issue 2 years ago • 4 comments

What does this PR do ?

Upgrade koncorde version to 4.0.3

ci-allow-merge-into: master

Shiranuit avatar Jul 25 '22 16:07 Shiranuit

Executed Checks

:heavy_check_mark: Branch Merge Check

:heavy_check_mark: Changelog Tag Check

:heavy_check_mark: PR Body Check

Generated by :no_entry_sign: dangerJS against d4f27c32200d10bcc1ffaff61e61df00fde9ebb3

kuzzle avatar Jul 25 '22 16:07 kuzzle

Codecov Report

Merging #2373 (174053a) into 2-dev (3ba51d0) will not change coverage. The diff coverage is 91.42%.

:exclamation: Current head 174053a differs from pull request most recent head d4f27c3. Consider uploading reports for the commit d4f27c3 to get more accurate results

@@           Coverage Diff           @@
##            2-dev    #2373   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files         116      116           
  Lines        8125     8125           
=======================================
  Hits         7404     7404           
  Misses        721      721           
Impacted Files Coverage Δ
lib/api/controllers/index.js 100.00% <ø> (ø)
lib/cluster/subscriber.js 95.27% <ø> (ø)
lib/cluster/workers/IDCardRenewer.js 69.09% <ø> (ø)
lib/config/index.js 93.06% <ø> (ø)
lib/core/auth/formatProcessing.js 100.00% <ø> (ø)
lib/core/auth/passportResponse.js 100.00% <ø> (ø)
lib/core/auth/passportWrapper.js 100.00% <ø> (ø)
lib/core/cache/cacheDbEnum.js 100.00% <ø> (ø)
lib/core/cache/cacheEngine.js 96.36% <ø> (ø)
lib/core/network/accessLogger.js 86.81% <ø> (ø)
... and 125 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 25 '22 16:07 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.3% 10.3% Duplication

sonarqubecloud[bot] avatar Jul 27 '22 10:07 sonarqubecloud[bot]

Strange, looks like we had something unmerged before

Those are mainly changes from Prettier that were done on master but never merged back on 2-dev So there was lots of conflics because some Pull Requests were already merged on 2-dev before we did merge master back into 2-dev

Shiranuit avatar Jul 27 '22 10:07 Shiranuit

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 31 '22 12:08 sonarqubecloud[bot]