kuzzle-admin-console icon indicating copy to clipboard operation
kuzzle-admin-console copied to clipboard

Autofocus modifier fix

Open pierreminik opened this issue 3 years ago • 8 comments

What does this PR do ?

This PR implement suggestions in issue #972, ignoring meta keys in the search field auto focus feature.

How should this be manually tested?

  • Step 1 : In the data tab go into an index and collection
  • Step 2 : Press cmd + c or corresponding copy-paste key for your OS and make sure the search field isn't auto focused
  • Step 3 : Press c without any meta modifier keys to make sure the search field is auto focused

Other changes

The PR also updates the policy JSON-value example to reflect expected array value for the restrictedTo property (in the Create Profile-screen).

pierreminik avatar Oct 21 '21 20:10 pierreminik

✔️ Deploy Preview for heuristic-goodall-67c4b1 ready!

🔨 Explore the source changes: bacbe121aec1023fa0a17711779c6f40f09680ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/heuristic-goodall-67c4b1/deploys/617ab415adc2e20008e24c47

😎 Browse the preview: https://deploy-preview-973--heuristic-goodall-67c4b1.netlify.app/

netlify[bot] avatar Oct 21 '21 20:10 netlify[bot]

Hi Pierre, thanks for your contribution, I will review this ASAP

xbill82 avatar Oct 22 '21 09:10 xbill82

Linting job failed because you probably have some Prettier or other automatic linter adding trailing commas not complying to our eslint rules, please fix your settings (or just run eslint --fix on the files)

xbill82 avatar Oct 28 '21 08:10 xbill82

eslint —fix didn’t it solve it.

I added a prettier rule to trailingComma: “none” which fixes the commas but I gotta find the one that fixes the parentheses around single arguments in arrow functions.

Mind if I commit the prettier rule update?

pierreminik avatar Oct 28 '21 14:10 pierreminik

Oh, actually no, we don't mind... It's a good thing to update it since we don't keep track of Prettier anymore (we uninstalled it and just use ESLint --fix as a prettifier)

xbill82 avatar Oct 28 '21 14:10 xbill82

Prettier v1.9 is needed to lint for x => x. 😔

pierreminik avatar Oct 28 '21 14:10 pierreminik

My advice is to deactivate Prettier for the workspace and just fix the lint errors.

xbill82 avatar Oct 28 '21 14:10 xbill82

Hope this fixed the formatting.🤞

pierreminik avatar Oct 28 '21 14:10 pierreminik

Closing this as it is old now. Feel free to reopen if feature is this fix is needed

rolljee avatar May 14 '23 12:05 rolljee