coreblocks icon indicating copy to clipboard operation
coreblocks copied to clipboard

Published 20 hours ago • verified publisher icon kuznia-rdzeni

Precommit using validate_arguments

Open tilk opened this issue 10 months ago • 0 comments

This PR makes the precommit method in ROB runnable only if the rob_id from its argument matches. This allows to eliminate m.If expressions comparing rob_ids in FUs.

What do you think? Is this a good idea? I kind of like it because this seems to fit better to Transactron's philosophy: actions which are impossible due to external factors are not performed because of methods not being ready.

This PR depends on #663 and #679.

TODO:

  • [x] Solve #678
  • [x] Fix tests

tilk avatar Apr 23 '24 11:04 tilk