Robin Kuzmin
The Native Simulator has the [Dump](https://github.com/microsoft/qsharp-runtime/blob/47237cef4570025067f8f58b79b910e6d224b67e/src/Simulation/Native/src/simulator/capi.cpp#L203) call with the following [declaration](https://github.com/microsoft/qsharp-runtime/blob/47237cef4570025067f8f58b79b910e6d224b67e/src/Simulation/Native/src/simulator/capi.hpp#L22): ```c++ MICROSOFT_QUANTUM_DECL void Dump(_In_ unsigned sid, _In_ bool (*callback)(size_t, double, double)); ``` Its second parameter's type is defined _in-place_,...
https://github.com/microsoft/qsharp-runtime/search?q=MICROSOFT_QUANTUM_DECL_IMPORT `MICROSOFT_QUANTUM_DECL_IMPORT` is likely never used. Consider removing from [config.hpp.in](https://github.com/microsoft/qsharp-runtime/blob/main/src/Simulation/Native/src/config.hpp.in), [config.hpp](https://github.com/microsoft/qsharp-runtime/blob/main/src/Simulation/Native/src/config.hpp) --- In Native Simulator, [class Simulator](https://github.com/microsoft/qsharp-runtime/blob/75b616f710ea6ac6836265a2781a3a4d52037959/src/Simulation/Native/src/simulator/simulator.hpp#L23), a number of member functions contain the fragment [`recursive_lock_type l(mutex())`](https://github.com/microsoft/qsharp-runtime/blob/75b616f710ea6ac6836265a2781a3a4d52037959/src/Simulation/Native/src/simulator/simulator.hpp#L295). This fragment confuses...
Request bettinaheim: The thrown std::runtime_error that is used everywhere throughout the QIR runtime results in a somewhat uninformative pop up window that merely states "Debug Error ... abort() has been...
Details are [here](https://github.com/microsoft/qsharp-runtime/pull/598#discussion_r606309621).
The standard of C and C++ assumes by default that the code is compiled in debug mode (which affects such things as, e.g. [assert()](https://man7.org/linux/man-pages/man3/assert.3.html) macro). If the developer wants to...
On https://github.com/microsoft/qsharp-runtime (README.md) the instructions to build are different for _Win_ and for _Linux/MacOS_. Consider unifying to **For all OSs:** bootstrap.ps1 dotnet build Simulation.sln dotnet build src\Simulation\Native\build\quantum-simulator.sln (Why this currently...
Currently the logic in the source files takes too long to understand (and to make sure it is correct). Consider simplifying the set of data types [`PTuple`](https://github.com/microsoft/qsharp-runtime/blob/7825716533b4669c46fd8f9f85804b0195e55cd7/src/QirRuntime/public/QirTypes.hpp#L61), [`QirTupleHeader`](https://github.com/microsoft/qsharp-runtime/blob/7825716533b4669c46fd8f9f85804b0195e55cd7/src/QirRuntime/public/QirTypes.hpp#L62), [`TupleWithControls`](https://github.com/microsoft/qsharp-runtime/blob/7825716533b4669c46fd8f9f85804b0195e55cd7/src/QirRuntime/public/QirTypes.hpp#L91), the...
The section is available [here](https://github.com/microsoft/iqsharp#data-collection) and [here](https://github.com/microsoft/iqsharp/blob/main/PRIVACY.md#data-collection). Consider de-duplicating.
Rewrite the README.md in the following directories to reflect the latest updates done by [Replace C++ QIR Runtime with Rust QIR stdlib](https://github.com/microsoft/qsharp-runtime/pull/1087) PR. qsharp-compiler\examples\QIR\Optimization\ qsharp-compiler\examples\QIR\Simulation\ qsharp-compiler\examples\QIR\Simulation\StateSimulator\ qsharp-compiler\examples\QIR\Simulation\TraceSimulator\ qsharp-compiler\src\QsCompiler\QirGeneration\ Related [PR](https://github.com/microsoft/qsharp-compiler/pull/1559)....
**2022.09.15: Likely to get deprecated after migrating to Rust.** Upon [migrating from Clang-13 to Clang-14](https://github.com/microsoft/qsharp-runtime/pull/1065) some of the test cases of the test [src/Qir/Tests/FullstateSimulator/FullstateSimulatorTests.cpp](https://github.com/microsoft/qsharp-runtime/blob/main/src/Qir/Tests/FullstateSimulator/FullstateSimulatorTests.cpp) start failing (for pipeline `microsoft.qsharp-runtime.sanitized (Build...