Kaan Uzdoğan

Results 277 comments of Kaan Uzdoğan

It is still failing here. Check the `contractFetchAddress`. Also, rebase or merge from staging again to avoid conflicts after the other PR.

Closing. Please open a new PR if you still want to add the chain

Same problem here. I set visible to false, then navigate to another screen. But the Dialog component does not unmount.

Ok found a workaround: We refer to child component and call `handleDismiss()` on Dialog. Set a ReactRef in the constructor: ``` constructor(props){ super(props); this.dialogRef = React.createRef(); this.state = { ......

@Jeevan-J Yes it seems, but it verifies on Etherscan and Etherscan verification does not require the metadata file. If you're interested [this article](https://docs.sourcify.dev/blog/verify-contracts-perfectly/) explains the difference in detail

@tom2drum Hi, thanks for bringing this up. Yes we will add a translation map if we do any changes to the metadata, as this would break the metadata hash. We...

Hi Rim. Thanks for bringing this up. This also breaks the IPFS hash of the metadata, even though the contract is marked as a `full_match`. Here, normally the metadata must...

I thought we were modifying the metadata.json file which would change the file's hash but apparently, we are not doing that but only changing the folder names in the filesystem....

@rimrakhimov Curious, was this an example you came up with or something you observed in practice?

URLEncoding is fine as an example but not a solution. We should not change the file names as much as possible. Another implication of this, I realized, is we currently...