feedparser icon indicating copy to clipboard operation
feedparser copied to clipboard

'updated' kludge status

Open dmwyatt opened this issue 2 years ago • 0 comments

I just spent a while trying to figure out why this code didn't work as expected:

field = 'updated'
# `data` is a FeedParserDict retrieved from `parsed_feed.feed`...
if field in data and data[field]:
    # do a thing with 'updated'

I found this in the source code: https://github.com/kurtmckee/feedparser/blob/e6a1fb846af30abe67105fe446b3035a8ce8d9bc/feedparser/util.py#L73-L90

  1. Those issues listed in the comment don't seem to have anything to do with this behavior? Maybe from a previous issue tracker?
  2. How long is this going to be here temporarily? 😀 A brief git blame shows its been in the code for at least 8 years when it was last moved to the utils.py file. I didn't dig any further to see when it was added prior to that.
  3. Since this code was getting run in a pytest test, and the failure included a couple hundred lines of debug information, I missed the warning that the code raises.

dmwyatt avatar Aug 25 '23 14:08 dmwyatt