ember-indexeddb-adapter icon indicating copy to clipboard operation
ember-indexeddb-adapter copied to clipboard

Published 20 hours ago • verified publisher icon kurko

Bug fixes

Open mattmarcum opened this issue 10 years ago • 2 comments

This fixes two bugs, one was happening when deleting a record, json was getting returned causing problems for ember-data: http://discuss.emberjs.com/t/assertion-failure-when-deleting-record-with-hasmany-relationship/4537/2 - this fixed worked here too, removing the json returned from the adapter fixed the assertion failure.

The second bug was harder to track down, when loading data from indexeddb data was getting normalized twice, this would cause some transforms (like date) not to work the second time. extractArray in the serializer was normalizing the payload after extractSingle had already normalized it. This seems to work better.

mattmarcum avatar Jul 20 '14 10:07 mattmarcum

@mattmarcum could you write some tests for these bugs? I can't accept this without tests. I don't have the time right now to write tests myself, so if you need this soon, please write some specs.

I can help you if you want.

kurko avatar Jul 31 '14 15:07 kurko

I'm seeing failing tests just on master itself, I've tried fixing some of those but there's still a few more. When I get some time I'll go back and try to fix all of them. Kind of pointless to write new tests when the old ones are still failing. I'll try and work on it this weekend.

mattmarcum avatar Jul 31 '14 17:07 mattmarcum