Toby Burress

Results 37 comments of Toby Burress

It may be that sometimes people want auth tokens, but probably not usually.

So I see it in two places, when the configs are printed, and when the debug RoundTripper prints the Authorization header. It might suffice to: * Modify the RoundTripper to...

It looks like dumping the HTTP requests and response uses httputil.DumpRequest/DumpResponse. While economical, internally these end up slurping the body of every request and response into memory as they go...

Probably a use-after-close?

This feels like an issue in Blazer but let me see if I can get a test case failing. This code is possibly more complicated than it ought to be...

I suspect you've surfaced a bug where if Resume is true but there's nothing to resume it just blows up.

Thanks for catching this! Try with the latest commit, you should be good.

Does this happen with any invocation? I have a zfs box around here somewhere I can try to test this on, but if you can reproduce it with the environment...

Oooh okay so what's happening is that to resume the large file, the checksums of the already-uploaded chunks have to match the checksums of the corresponding chunks of the current...

I'm not familiar with zfsbackup-go but it sounds to me like it's starting the upload from the beginning with `w.Resume = true`, which works when the stream is the same,...